MOC: long id3 tags cut at a certain lenght

hi,

when displaying long id3-tags, MOC cuts the tag at a certain lenght.

for example:

Nine Inch Nails - Another Version of the Truth (Kronos Quartet and Enrique Gonzalez Muller) [Y34RZ3R0R3M1X3D]

results in

Nine Inch Nails - Another Version of the Truth (Kronos Quartet and Enrique Gonzalez Muller) [Y34R]

in my ~/.moc/config i've played around with the "TagsCacheSize" option, from 254 to 512 KB, doesnt seem to help.
the "FormatString" is set to "%(a:%a - :)%(t:%t:) [%(A:%A:)]".

is there some way to display those long id3-tags? i hope this last little annoying problem is solvable somehow.. if so, i would mark MOC as nearly perfect! :)

thank you in advance,

ryz

AFAIK TagsCacheSize is only for space that can have tags list in memory that means it do not change tags max length.
From short look to code I think that fix should be something like this:
<br /> --- playlist.c.org 2008-03-20 00:54:32.000000000 +0100<br /> +++ playlist.c 2008-03-20 00:54:47.000000000 +0100<br /> @@ -589,7 +589,7 @@<br /> /* Build file title from struct file_tags. Returned memory is malloc()ed. */<br /> char *build_title (const struct file_tags *tags)<br /> {<br /> - char title[100];<br /> + char title[500];</p> <p> do_title_expn (title, sizeof(title), options_get_str("FormatString"),<br /> tags);<br />

thank you golemj,

i should practice some more further thinking. :)

anyway, my problem is solved, many thanks!

ryz

PS: i would be glad if this little 'patch' finds its way in to the next MOC-release!

According to daper it should.

Thanks for the patch, I've increased the buffer to 512 and the buffer in do_title_expt from 100 to 256.

--
Damian Pietras - MOC developer

This was only quick patch. I think that better patch would be to create config file option for this.

The proper would be to allocate the buffer dynamically, but the code isn't so simple to do that in few lines I think.

--
Damian Pietras - MOC developer