Quit immediately after open hangs until tags are read

Submitted by mjsir911 on Thu, 2019-02-28 13:52

Forums:

Hi all, new user to moc (loving it) and I am immediately stumbling up against some unfortunate behavior:

When I open moc after already running a server in the background loaded with a big playlist (652 lines in .m3u file) and immediately closing it, it does not close. It freezes with the status bar reporting "Reading tags... " During this time I can see the playlist items getting updated from their file names to the tags.

After about 8 seconds (time mocp, q immediately), moc finally quits.

Expected behavior: moc quits as soon as I hit the `q` key, no matter if all the tags are loaded or not

As a new user this was a bit disorienting at first until I figured out what was going on.

Thanks for such a wonderful application.

mjsir911

Thu, 2019-02-28 14:00

On further investigation, this is addressed in the FAQ.
This is a reasonable fix, but it's still confusing for new users having to investigate around to the FAQ.
Would it be possible to make the option ShowTime = yes default?

mjsir911

Thu, 2019-02-28 14:03

On further investigation, the proposed fix ShowTime = yes does nothing
$ mocp --version
This is : Music On Console
Version : 2.5.2
Revision : Unversioned directory
Built : Feb 28 2019 08:24:31
Compiled with : ALSA JACK Network streams
Running on : Linux 4.14.83-gentoo x86_64
Author : Damian Pietras
Homepage : http://moc.daper.net/
E-Mail : mocmaint@daper.net
Copyright : (C) 2003-2016 Damian Pietras and others
License : GNU General Public License, version 2 or later

tomaszg

Thu, 2019-02-28 14:10

ShowTime would "fix" it only if MOC was running for some time before you quit. Tags would then be read in background. Only reasonable "fix" right now is to use ctrl-c to cancel reading tags and saving playlist. Increasing cache size could also help since current default is ridiculously low for modern computers.

Real fix would require a change in MOC's behaviour. For example saving working playlists without tags would probably make sense (not to mention it would simplify other problems and allow fixing other issues like number padding in tags).

tomaszg

Tue, 2019-03-05 18:40

If you're interested I just added a patch to my personal fork of MOC which solves the problem by saving playlists without tags: https://gitlab.com/tomaszg/mocp/commit/d1c5ef1093b85f37ccdd08ec3e358fde8c31e77e