reencode file names using librcc

Submitted by daper on Sun, 2006-11-05 14:19

Alexey Gladkov made another patch that enables MOC to use librcc not only for mp3 tags, but also for file names. You can download it here.

Patches:

Comments

diligent

Sat, 2006-11-11 11:27

I have some errors with this patch:

gcc -g -O2 -Wall -W -I/usr/include/alsa -o mocp log.o protocol.o server.o main.o common.o playlist.o fifo_buf.o out_buf.o audio.o decoder.o interface.o interface_elements.o menu.o files.o options.o player.o playlist_file.o themes.o keys.o ltdl.o io.o compat.o audio_conversion.o rbtree.o tags_cache.o utf8.o oss.o alsa.o jack.o null_out.o -Wl,--export-dynamic -pthread /usr/lib/libiconv.so /usr/lib/libasound.so /usr/lib/libjack.so -lncursesw -lm -lpthread -ldl
utf8.o(.text+0x18): In function `iconv_rcc':
/home/diligent/moc-2.4.1/utf8.c:66: undefined reference to `rccSizedFrom'
utf8.o(.text+0x35):/home/diligent/moc-2.4.1/utf8.c:68: undefined reference to `rccSizedToCharset'
utf8.o(.text+0x80b): In function `utf8_init':
/home/diligent/moc-2.4.1/utf8.c:372: undefined reference to `rccInit'
utf8.o(.text+0x81f):/home/diligent/moc-2.4.1/utf8.c:373: undefined reference to `rccInitDefaultContext'
utf8.o(.text+0x82e):/home/diligent/moc-2.4.1/utf8.c:374: undefined reference to `rccLoad'
utf8.o(.text+0x83c):/home/diligent/moc-2.4.1/utf8.c:375: undefined reference to `rccSetOption'
utf8.o(.text+0x84a):/home/diligent/moc-2.4.1/utf8.c:377: undefined reference to `rccSetOption'
utf8.o(.text+0x743): In function `iconv_cleanup':
/home/diligent/moc-2.4.1/utf8.c:327: undefined reference to `rccFree'
collect2: ld returned 1 exit status

What version of librcc and moc do you use?
I have: librcc-0.2.3, librcd-0.1.8, moc-2.4.1.

P.S. (offtopic to site creator) Change link for Download on left side - as it relative, it's takes various url on various pages.

daper

Sat, 2006-11-11 18:38

Try make distclean && ./configure && make if it will not help, do ./configure LDFLAGS='-Lrcc'. Please write which (if any) solution worked.

I'll fix the download link, thanks.

--
Damian Pietras - MOC developer

diligent

Tue, 2006-11-14 18:17

No, don't worked. I think this patch not worked with moc 2.4.1.
I tried svn and all compiled and worked fine!

But I see two small disadvantages:
1) If mocp worked on non-utf8 (koi8, for instance) locale when song changed some utf-8 string trying to be written (maybe song title?) and ofcourse I see some notexpected characters and beep :). In utf8-locale all worked fine, but in 2.3.x with old patch i didn't see this error.
2) title of moc filemanager (path) still not worked with librcc.

Anyway, thanks for this patch - main problem solved.

P.S. Sorry for my english, if something wrong, or not understandable - I'll tried to write more clearly.

valeri_ufo

Mon, 2006-11-27 00:37

This patch works, thanks to Alexey for the patch.
And thank you daper for the new release!