[Patch] dual call file_type()

Submitted by jo_link_noir on Sun, 2015-04-05 05:19

Forums:

Hi,

Looking at the sources, I noticed a double call file_info() in playlist.c

--- playlist.c.old 2015-04-05 06:59:34.089782732 +0200
+++ playlist.c 2015-04-05 06:59:44.269822667 +0200
@@ -673,7 +673,6 @@
if (plist->items[num].file) {
rb_delete (&plist->search_tree, file);
free (plist->items[num].file);
- plist->items[num].type = file_type (file);
}

plist->items[num].file = xstrdup (file);

The next line already contains `plist->items[num].type = file_type (file);`

jcf

Sun, 2015-04-05 22:34

Thanks, "jo_link_noir". It certainly does do some needless work there.

There was some discussion about excessive calls to stat(2) on remote file systems and your patch will help to reduce this count a little.

I'll schedule it to be committed.

jcf

Tue, 2015-04-14 21:44

Committed today as r2771: Remove redundant call to file_type().